Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IMN-616 BFF Tools router #976

Merged
merged 452 commits into from
Oct 11, 2024
Merged

IMN-616 BFF Tools router #976

merged 452 commits into from
Oct 11, 2024

Conversation

paologaleotti
Copy link
Collaborator

@paologaleotti paologaleotti commented Sep 17, 2024

Merge after #956 !!!

This PR adds the Tools router to BFF

The implementation differs a bit from scala (see this slack thread https://buildo.slack.com/archives/C0527LU1K4G/p1726583989026809).

When reviewing please pay particular attention to the logic behind the error handling (handleValidationResults) and retrieveKey, as it is not a direct porting of scala logic.

Copy link
Collaborator

@ecamellini ecamellini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dismissing my previous change request, once the remaining comments are resolved works for me :)

@ecamellini ecamellini dismissed their stale review October 10, 2024 09:52

Avoid blocking this PR

@paologaleotti paologaleotti merged commit f517ccf into main Oct 11, 2024
43 checks passed
@paologaleotti paologaleotti deleted the IMN-616_tools_router branch October 11, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants